Skip to content

Add /brand-kit to framer rewrites #6624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

Add /brand-kit to framer rewrites #6624

merged 1 commit into from
Apr 2, 2025

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Apr 2, 2025 •
edited by pr-codex bot
Loading

Added a rewrite rule for the /brand-kit path in the Framer rewrites configuration.

PR-Codex overview

This PR updates the apps/dashboard/framer-rewrites.js file by adding a new route for the brand kit section, indicating an enhancement in the dashboard's navigation.

Detailed summary

  • Added a new route for the brand kit section: "/brand-kit"

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 5:59pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 2, 2025 5:59pm
login ⬜️ Skipped (Inspect) Apr 2, 2025 5:59pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 2, 2025 5:59pm
wallet-ui ⬜️ Skipped (Inspect) Apr 2, 2025 5:59pm

@vercel vercel bot temporarily deployed to Preview – login April 2, 2025 16:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 2, 2025 16:17 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4847ada

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui April 2, 2025 16:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 2, 2025 16:17 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 2, 2025
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Apr 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review April 2, 2025 16:18
@jnsdls jnsdls requested review from a team as code owners April 2, 2025 16:18
@codecov
Copy link

codecov bot commented Apr 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (08eea95) to head (4847ada).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6624   +/-   ##
=======================================
  Coverage   54.96%   54.96%           
=======================================
  Files         887      887           
  Lines       55652    55652           
  Branches     3798     3798           
=======================================
  Hits        30591    30591           
  Misses      24966    24966           
  Partials       95       95
Flag Coverage Δ
packages 54.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.49 KB (0%) 950 ms (0%) 209 ms (+141.36% 🔺) 1.2 s
thirdweb (cjs) 129.89 KB (0%) 2.6 s (0%) 306 ms (+29.06% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 85 ms (+1000.27% 🔺) 197 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 35 ms (+1462.28% 🔺) 45 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 133 ms (+656.16% 🔺) 520 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 2, 2025 •
edited
Loading

Merge activity

@jnsdls
Add /brand-kit to framer rewrites (#6624)
4847ada 
Added a rewrite rule for the `/brand-kit` path in the Framer rewrites configuration.
@graphite-app graphite-app bot force-pushed the Add_/brand-kit_to_framer_rewrites branch from a3a14c1 to 4847ada Compare April 2, 2025 17:53
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 2, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 2, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 2, 2025 17:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 2, 2025 17:53 Inactive
@graphite-app graphite-app bot merged commit 4847ada into main Apr 2, 2025
32 checks passed
@graphite-app graphite-app bot deleted the Add_/brand-kit_to_framer_rewrites branch April 2, 2025 18:01
@vercel vercel bot temporarily deployed to Production – login April 2, 2025 18:01 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 2, 2025 18:01 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 2, 2025 18:01 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 2, 2025 18:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@jnsdls jnsdls

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @joaquim-verges